[Webkit-unassigned] [Bug 223236] [SOUP] SOUP3 crashes inside soup_message_set_request_body

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=223236

--- Comment #9 from Adrian Perez <aperez at igalia.com> ---
(In reply to Carlos Garcia Campos from comment #8)
> Comment on attachment 423468 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=423468&action=review
> 
> >> Source/WebCore/platform/network/soup/WebKitFormDataInputStream.cpp:137
> >> +    // GFileInputStream is not pollable, so the stream is only pollable if FormData doesn't contain EncodedFileData elements.
> > 
> > I wonder if it could be an options to check whether a GInputStream is a GUnixInputStream
> > (which does implement GPollableInputStream) which would make the file elements pollable,
> > or whether the GInputStream implements the GFileDescriptorBased interface, in which case
> > we could use the _get_fd() method and use GPollFD or similar ��️
> > 
> > (No need to change anything in this patch, by the way, this is just me mulling ideas
> > over. If you think any of this makes sense for a follow-up patch it would be nice
> > to write it down as a TODO and/or make a new Bugzilla issue to track it.)
> 
> We are always reading local files, so it's always GFileInputStream and not
> pollable.

��️

> >> Source/WebCore/platform/network/soup/WebKitFormDataInputStream.cpp:177
> >> +    return g_pollable_source_new_full(stream, base.get(), cancellable);
> > 
> > Aren't these two lines equivalent to a plain g_pollable_input_stream_create_source() call?
> > As in:
> > 
> >    return g_pollable_input_stream_create_source(stream, cancellable);
> 
> This is the implementation of g_pollable_input_stream_create_source().

Right, I did not notice at first, my brain is a bit foggy this morning ��️

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210318/9b2c735a/attachment.htm>