[Webkit-unassigned] [Bug 222972] [WPE][GTK] TestJSC incorrectly expects garbage collector to collect variables still on the stack

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=222972

Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cgarcia at igalia.com

--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 422753
  --> https://bugs.webkit.org/attachment.cgi?id=422753
Yucky test patch that fixes this test

View in context: https://bugs.webkit.org/attachment.cgi?id=422753&action=review

> a/Tools/TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:118
> +static void jscContextSanitizeStack(JSCContext* context)
> +{
> +    JSCVirtualMachine* jscVM = jsc_context_get_virtual_machine(context);
> +    JSContextGroupRef jsContextGroup = jscVirtualMachineGetContextGroup(jscVM);
> +    JSC::VM& vm = *toJS(jsContextGroup);
> +    JSC::JSLockHolder locker(vm);
> +    sanitizeStackForVM(vm);
> +}

I think we could add JSCContextInternal.h with jscContextGarbageCollect() and jscContextSanitizeStack() implemented in JSCContext.cpp. That way we only need to include the internal header from the tests and not use the C API nor internal API from tests

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210318/c732d26c/attachment-0001.htm>