[Webkit-unassigned] [Bug 191627] [css-grid] Incorrect track sizing when using relative sized items in 'auto' column tracks

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=191627

--- Comment #20 from zsun at igalia.com ---
(In reply to Javier Fernandez from comment #18)
> Comment on attachment 423380 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=423380&action=review
> 
> Do we know the cause of the ios failures ?

Not sure. This patch has improved the test result in ios but not fully fixed it.
The original test expected results for ios are different from the one for mac as well.
> 
> > Source/WebCore/ChangeLog:8
> > +        For grid items, containing block is the grea area. During the GridTrackSizingAlgorithm, we determine
> 
> s/grea/grid
> 
Updated.
> > Source/WebCore/rendering/RenderBox.cpp:2058
> > +        return overridingContainingBlockContentLogicalHeight().valueOr(0_lu);
> 
> I'm not sure we want to return 0 in case of nullopt, which would mean we
> have an indefinite grid area size. I'm fine with this change for now, but
> I'd like to add a FIXME comment to review this if necessary. The idea
> solution would be to use an optional value, but I admit it'd imply a bigger
> change, since this function is widely consumed in RenderBox layout logic.

Added a FIXME comment.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210317/9f2e3f57/attachment.htm>