[Webkit-unassigned] [Bug 191627] [css-grid] Incorrect track sizing when using relative sized items in 'auto' column tracks

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=191627

--- Comment #18 from Javier Fernandez <jfernandez at igalia.com> ---
Comment on attachment 423380
  --> https://bugs.webkit.org/attachment.cgi?id=423380
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423380&action=review

Do we know the cause of the ios failures ?

> Source/WebCore/ChangeLog:8
> +        For grid items, containing block is the grea area. During the GridTrackSizingAlgorithm, we determine

s/grea/grid

> Source/WebCore/rendering/RenderBox.cpp:2058
> +        return overridingContainingBlockContentLogicalHeight().valueOr(0_lu);

I'm not sure we want to return 0 in case of nullopt, which would mean we have an indefinite grid area size. I'm fine with this change for now, but I'd like to add a FIXME comment to review this if necessary. The idea solution would be to use an optional value, but I admit it'd imply a bigger change, since this function is widely consumed in RenderBox layout logic.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210317/81e5ed53/attachment.htm>