[Webkit-unassigned] [Bug 222720] REGRESSION(r272900): Nullptr crash in ComposedTreeIterator::traverseNextInShadowTree() via ShadowRoot::hostChildElementDidChange

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=222720

--- Comment #30 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Carlos Garcia Campos from comment #27)
> Comment on attachment 423315 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=423315&action=review
> 
> >> Source/WebCore/dom/ComposedTreeIterator.cpp:166
> >> +            ASSERT(assignedNode);
> > 
> > Why assert this is non-null but not assert that parentElement is non-null?
> > 
> > I suggest we assert both or neither.
> 
> Good point, I guess we could add both asserts then.

It turns out that parentElement() can be nullptr... It doesn't crash because it's not actually used expect for comparing its address in ElementAndTextDescendantIterator::ElementAndTextDescendantIterator(), so it's always comparing to nullptr in that case.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210317/24b9fd01/attachment-0001.htm>