[Webkit-unassigned] [Bug 223205] Add CSSValuePair.h in preparation for Pair.h refactor

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=223205

--- Comment #9 from Tyler Wilcock <twilco.o at protonmail.com> ---
(In reply to Darin Adler from comment #8)
> Comment on attachment 423358 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=423358&action=review
> 
> > Source/WebCore/css/CSSValue.h:80
> > +    String separatorCssText() const;
> 
> For efficiency, this should return ASCIILiteral instead of String. It never
> needs to return a value that’s not an ASCII literal, and this saves some
> memory allocation.
> 
> The name should be separatorCSSText, rather than separatorCssText.
> 
> > Source/WebCore/css/CSSValueList.cpp:89
> > +    String separator = separatorCssText();
> 
> If we change separatorCSSText to return an ASCIILiteral, that’s the type
> we’ll want for this local variable too. Could just use "auto".

Good to know, thanks!  I've made these changes here[1].  I'll mark this follow-up patch r? and cq? but feel free to wait to be sure EWS goes green first.

[1]: https://bugs.webkit.org/show_bug.cgi?id=223300

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210317/e7f093b2/attachment.htm>