[Webkit-unassigned] [Bug 223205] Add CSSValuePair.h in preparation for Pair.h refactor

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=223205

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com

--- Comment #8 from Darin Adler <darin at apple.com> ---
Comment on attachment 423358
  --> https://bugs.webkit.org/attachment.cgi?id=423358
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423358&action=review

> Source/WebCore/css/CSSValue.h:80
> +    String separatorCssText() const;

For efficiency, this should return ASCIILiteral instead of String. It never needs to return a value that’s not an ASCII literal, and this saves some memory allocation.

The name should be separatorCSSText, rather than separatorCssText.

> Source/WebCore/css/CSSValueList.cpp:89
> +    String separator = separatorCssText();

If we change separatorCSSText to return an ASCIILiteral, that’s the type we’ll want for this local variable too. Could just use "auto".

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210317/d40483ce/attachment.htm>