[Webkit-unassigned] [Bug 222720] REGRESSION(r272900): Nullptr crash in ComposedTreeIterator::traverseNextInShadowTree() via ShadowRoot::hostChildElementDidChange

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 16 15:12:26 PDT 2021


https://bugs.webkit.org/show_bug.cgi?id=222720

--- Comment #26 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 423315
  --> https://bugs.webkit.org/attachment.cgi?id=423315
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423315&action=review

> Source/WebCore/dom/ContainerNode.cpp:130
> +                children[i] = *child;
> +            else
> +                children.append(*child);

I don't think this will be efficient enough. We'd definitely need to perf-test this.
So let's not do that. That's just really asking for more trouble.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210316/14932796/attachment.htm>


More information about the webkit-unassigned mailing list