[Webkit-unassigned] [Bug 223205] Add CSSValuePair.h in preparation for Pair.h refactor

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 16 09:20:56 PDT 2021


https://bugs.webkit.org/show_bug.cgi?id=223205

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |simon.fraser at apple.com
 Attachment #423260|review?                     |review+
              Flags|                            |

--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 423260
  --> https://bugs.webkit.org/attachment.cgi?id=423260
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423260&action=review

> Source/WebCore/css/CSSValuePair.cpp:37
> +    return first + separatorCssText() + second;

makeString() might be more efficient.

> Source/WebCore/css/CSSValuePair.h:36
> + * Intended to replace Pair.h, which is only capable of containing CSSPrimitiveValues, and is not a sub-class of
> + * CSSValue itself. See https://bugs.webkit.org/show_bug.cgi?id=223204.

This comment won't be useful in the future when Pair.h is lost in the mists of time.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210316/8628aca2/attachment.htm>


More information about the webkit-unassigned mailing list