[Webkit-unassigned] [Bug 223236] [SOUP] SOUP3 crashes inside soup_message_set_request_body

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 16 05:54:40 PDT 2021


https://bugs.webkit.org/show_bug.cgi?id=223236

--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Daniel Kolesa from comment #3)
> i guess the thing to do here would be to just do the same as the soup2 code
> - i.e. read all into bytes, then set the request body from bytes rather than
> from the input stream...

That's problematic for long file uploads, for example. The WebKit stream can't be pollable because it used GFileInputStream internally that is not pollable. I can make it pollable and only return TRUE from can_poll when not having file streams. But the solution would be to make libsoup work without pollable streams, at least having fallback code that reads using the async apis into an intermediate buffer that is later used to write in the output.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210316/57cd7987/attachment-0001.htm>


More information about the webkit-unassigned mailing list