[Webkit-unassigned] [Bug 221783] ASSERTION FAILED: m_state == State::Committed in WebKit::FrameLoadState::didFailLoad()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=221783

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #423289|review?                     |review+
              Flags|                            |

--- Comment #14 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 423289
  --> https://bugs.webkit.org/attachment.cgi?id=423289
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423289&action=review

> Source/WebCore/editing/FrameSelection.h:302
> +    enum ShouldUpdateAppearance : bool { No, Yes };

Please use enum class, not enum.
Otherwise, there will be implicit type coercion between this type and bool,
and No/Yes will pollute the namespace within FrameSelection.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210316/7ccb2233/attachment-0001.htm>