[Webkit-unassigned] [Bug 222959] [CMake] Build fails on RISC-V with GCC 11

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=222959

--- Comment #22 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
Comment on attachment 422979
  --> https://bugs.webkit.org/attachment.cgi?id=422979
potential fix 4

View in context: https://bugs.webkit.org/attachment.cgi?id=422979&action=review

Some nitpicks with the format used for the Changelogs, commenting in-line.
Other than that I think the patch is fine.
Thanks for your patience :)

> ChangeLog:4
> +        Check for 1 byte atomic operations along with 64bit ones, some
> +        architevtures (e.g. RISCV) operations on less than 4 bytes are not lock-free

The title used on the Changelog files should be the same title used on the bug. So this title should be:
[CMake] Build fails on RISC-V with GCC 11

The explanation "Check for 1 byte atomic operations along with 64bit ones, some architevtures (e.g. RISCV) operations on less than 4 bytes are not lock-free" should go under the "Reviewed by ... line

> ChangeLog:7
> +        Reviewed by Reviewed by NOBODY (OOPS!).

This reviewed line has errors. It should be "Reviewed by NOBODY (OOPS!)." and not " Reviewed by Reviewed by NOBODY (OOPS!)."

> Source/JavaScriptCore/ChangeLog:3
> +        Use renamed variable ATOMICS_REQUIRE_LIBATOMIC instead of ATOMIC_INT64_REQUIRES_LIBATOMIC

Here the title should be the same than above

> Source/JavaScriptCore/ChangeLog:7
> +        https://bugs.webkit.org/show_bug.cgi?id=222959
> +
> +        Reviewed by NOBODY (OOPS!).
> +

Below this line is where the explanation "Use renamed variable ATOMICS_REQUIRE_LIBATOMIC instead of ATOMIC_INT64_REQUIRES_LIBATOMIC" should be written, but the subject (what goes above the bugzilla bug link) should be the same than the bug title.

> Source/WTF/ChangeLog:3
> +        Link with libatomic if ATOMICS_REQUIRE_LIBATOMIC is set.

Here the same issues: the title should be the one of the bug, and this explanation should go below the "Reviewed by" line

> Source/WebKit/ChangeLog:3
> +        Use renamed ATOMICS_REQUIRE_LIBATOMIC instead of ATOMIC_INT64_REQUIRES_LIBATOMIC.

Same issue with the title (should be the same title than the bug)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210316/39b9bb91/attachment.htm>