[Webkit-unassigned] [Bug 221783] ASSERTION FAILED: m_state == State::Committed in WebKit::FrameLoadState::didFailLoad()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=221783

--- Comment #12 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 423277
  --> https://bugs.webkit.org/attachment.cgi?id=423277
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423277&action=review

>> Source/WebCore/editing/FrameSelection.cpp:184
>> +    setCaretVisibility(activeAndFocused ? Visible : Hidden, false);
> 
> Please add new enum class maybe something like: ShouldUpdateAppearance { Yes, No }

Or preferably:
enum class ShouldUpdateAppearance : bool { No, Yes }

(using bool underlying type and 0 meaning No, not Yes).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210316/b3110862/attachment-0001.htm>