[Webkit-unassigned] [Bug 222376] [css-grid] Replace the use of -1 with WTF::nullopt

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=222376

--- Comment #21 from zsun at igalia.com ---
(In reply to Javier Fernandez from comment #19)
> Comment on attachment 423033 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=423033&action=review
> 
> r=me
> 
> > Source/WebCore/ChangeLog:8
> > +        This change replaces -1 with nullopt in grid to indicate indefinite for funtions that
> 
> s/funtions/functions
> 
> > Source/WebCore/ChangeLog:9
> > +        returns an Optional type. This change has exposed an issue when resolving replaced elemnt
> 
> s/elemnt/element
> 
> > Source/WebCore/rendering/RenderReplaced.cpp:357
> >          if (hasAutoHeightOrContainingBlockWithAutoHeight())
> 
> Nit: Maybe we can change this as well, something like this:
> 
> return !hasAutoHeightOrContainingBlockWithAutoHeight()

Updated. Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210315/b0ab3468/attachment.htm>