[Webkit-unassigned] [Bug 223204] New: Refactor Pair.h to CSSValuePair.h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=223204

            Bug ID: 223204
           Summary: Refactor Pair.h to CSSValuePair.h
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: CSS
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: twilco.o at protonmail.com

Tracking issue for refactoring Pair.h[1] to CSSValuePair.h.  Pair.h has a couple problems:

1. It's not a sub-class of CSSValue, making it awkward to use.
2. It can only contain CSSPrimitiveValues.

We should make a new pair class that doesn't have these shortcomings.

Some relevant FIXME-NEWPARSER comments:

https://github.com/WebKit/WebKit/blob/878494d4e4784e308ed3c21a5937a2818d5ee27d/Source/WebCore/css/parser/CSSPropertyParser.cpp#L66

> // FIXME-NEWPARSER: Replace Pair and Rect with actual CSSValue subclasses (CSSValuePair and CSSQuadValue).

https://github.com/WebKit/WebKit/blob/878494d4e4784e308ed3c21a5937a2818d5ee27d/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp#L647#L649

> // FIXME-NEWPARSER: Eventually we'd like this to use CSSCustomIdentValue, but we need
> // to do other plumbing work first (like changing Pair to CSSValuePair and make it not
> // use only primitive values).

[1]: https://github.com/WebKit/WebKit/blob/7e92dc9040eefad3bd0dadf86201eb601dfe82d3/Source/WebCore/css/Pair.h#L33

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210315/db5a385d/attachment.htm>