[Webkit-unassigned] [Bug 223067] [GTK] Bump API version when building with libsoup3

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=223067

--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 422926
  --> https://bugs.webkit.org/attachment.cgi?id=422926
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422926&action=review

>> Source/cmake/OptionsGTK.cmake:70
>> +WEBKIT_OPTION_DEFINE(ENABLE_QUARTZ_TARGET "Whether to enable support for the Quartz windowing target." PUBLIC ON)
> 
> Why is this unconditionally enabled now?

Because we don't have GTK_SUPPORTS_QUARTZ yet here. The GTK4 was wrong, we can't use build variables before WEBKIT_OPTION_END(). So I moved the find_package for GTK after that to check what gtk version to check for. So, targets options and enabled by default, but disabled below if GTK doesn't support them.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210312/e9828270/attachment.htm>