[Webkit-unassigned] [Bug 222376] [css-grid] Replace the use of -1 with WTF::nullopt

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=222376

--- Comment #17 from zsun at igalia.com ---
(In reply to Sergio Villar Senin from comment #14)
> Comment on attachment 422930 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=422930&action=review
> 
> Seems like you have to update the failed expectations of a test that is
> failing.
> 
Updated. This test is fixing at https://bugs.webkit.org/show_bug.cgi?id=191627.

> Looking great, I'm happy that we get rid of the -1's. It's a pitty that we
> cannot use LayoutSize and have to use width and height separatedely but it
> isn't a big deal.
> 
> > Source/WebCore/ChangeLog:7
> > +        returns an Optional type. This change has exposed an issue when resolving repalced elemnt
> 
> Nit: replaced element
> 
> > Source/WebCore/ChangeLog:11
> > +         
> 
> Extra line here. BTW this paragraph should go bellow the "Reviewed by" line

Updated. Thank you!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210312/f6d5cd91/attachment.htm>