[Webkit-unassigned] [Bug 222959] [CMake] Build fails on RISC-V with GCC 11

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=222959

Carlos Alberto Lopez Perez <clopez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |clopez at igalia.com

--- Comment #17 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
Comment on attachment 422956
  --> https://bugs.webkit.org/attachment.cgi?id=422956
potential fix 3

View in context: https://bugs.webkit.org/attachment.cgi?id=422956&action=review

> Source/WebKit/ChangeLog:4
> +        Use renamed ATOMICS_REQUIRE_LIBATOMIC instead of
> +       ATOMIC_INT64_REQUIRES_LIBATOMIC.

We don't usually wrap long lines on WebKit. The practice is to use just one line for all the subject even if this is many characters long.

> Source/WebKit/ChangeLog:6
> +
> +        https://bugs.webkit.org/show_bug.cgi?id=222959

Also we don't use an extra empty line between the subjet and the bug link

> Source/WebKit/ChangeLog:8
> +        Reviewed by OOPS.

This should be "Reviewed by NOBODY (OOPS!)."
That is important because the tooling we use to land patches looks for those exact words to later replace the "NOBODY (OOPS!)" with the name of the reviewer.

I know this sounds like a lot of bureaucracy at first, but once you get used to it is pretty straightforward.

To generate the changelogs we have a script. We don't create them by hand.
It is used like this:

Tools/Scripts/prepare-ChangeLog -b ${bugzillanumber} -g ${localgitcommitforchangelog}

For example, assuming you are checked out on the patch to upload and this patch is committed locally

Tools/Scripts/prepare-ChangeLog -b 222959 -g HEAD

It will generate the changelog files, then you just edit under the reviewed line it will appear the message of your local commit.. you edit that to tell a bit about what the patch does. Then you add the changelogs to git and commit them by amending the previos commit, then its ready to upload.

You can generate a patch and upload it here manually or you can use another script to upload the patch directly.

Tools/Scripts/webkit-patch upload -g ${localgitcommittobeuploaded} --suggest-reviewers

It will automatically detect the bug number where the patch should be uploaded from the changelog

> Source/cmake/WebKitCompilerFlags.cmake:284
>  if (COMPILER_IS_GCC_OR_CLANG)
>      set(ATOMIC_TEST_SOURCE "
> -        #include <atomic>
> -        int main() { std::atomic<int64_t> i(0); i++; return 0; }
> +	#include <atomic>
> +	int main() {
> +          std::atomic<bool> y (false);
> +          std::atomic<uint64_t> x (0);
> +          bool expected = true;
> +          bool j = y.compare_exchange_weak(expected,false);
> +          x++;
> +          return 0;
> +        }

The Early Warning System (EWS) bot for checking the style is complaining here about mixed spaces/tabs

ERROR: Source/cmake/WebKitCompilerFlags.cmake:276:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/cmake/WebKitCompilerFlags.cmake:277:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 8 files
program finished with exit code 1

^^ https://ews-build.webkit.org/#/builders/6/builds/42334

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210311/b35e6ed8/attachment-0001.htm>