[Webkit-unassigned] [Bug 222376] [css-grid] Replace the use of -1 with WTF::nullopt

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=222376

--- Comment #14 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 422930
  --> https://bugs.webkit.org/attachment.cgi?id=422930
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422930&action=review

Seems like you have to update the failed expectations of a test that is failing.

Looking great, I'm happy that we get rid of the -1's. It's a pitty that we cannot use LayoutSize and have to use width and height separatedely but it isn't a big deal.

> Source/WebCore/ChangeLog:7
> +        returns an Optional type. This change has exposed an issue when resolving repalced elemnt

Nit: replaced element

> Source/WebCore/ChangeLog:11
> +         

Extra line here. BTW this paragraph should go bellow the "Reviewed by" line

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210311/7acaa8f6/attachment-0001.htm>