[Webkit-unassigned] [Bug 223019] TestExpectations should be able to set an expectation based on GPU model

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 10 09:01:13 PST 2021


https://bugs.webkit.org/show_bug.cgi?id=223019

--- Comment #2 from Jonathan Bedard <jbedard at apple.com> ---
This is something one would think is simple, but it's more involved and not very generalizable. The place to start is Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py.

The trouble with this change is the way this really should work is that each test run generates a set of tags which describe it's run, and any string which is not PASS/FAIL/TIMEOUT/CRASH/SKIP/etc is considered an attribute tag. This is a refactor on my list of to-dos, but it's not high-priority at the moment.

I might consider seeing if we can get better test coverage by, for example, running the effected tests on only Intel, iOS Simulator or Apple Silicon even though those differentiators are not, strictly speaking, accurate. It's a bit hackey, but may be a better use of engineering time than doing things the "right" way

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210310/8f22441b/attachment.htm>


More information about the webkit-unassigned mailing list