[Webkit-unassigned] [Bug 222100] [css-grid] Fix min/max widths of grid affected by ancestor

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=222100

Sergio Villar Senin <svillar at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |svillar at igalia.com

--- Comment #18 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 422253
  --> https://bugs.webkit.org/attachment.cgi?id=422253
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422253&action=review

What I don't exactly understand is which cases fix this and why the setPreferredLogicalWidthsDirty() is not invoked in the specific subclass RenderFlexibleBox, RenderGrid... etc

> Source/WebCore/rendering/RenderBox.cpp:2490
> +    }

You can write this in a more compact way using some C++ fancyness

if (const RenderBox* cb = box->containingBlock(); !cb->preferredLogicalWidthsDirty())
    return false;

Also I guess this function is only meant to be used from updateLogicalWidth(). If that's indeed the case it'd be better to move it to a lambda inside that method.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210305/455428c6/attachment-0001.htm>