[Webkit-unassigned] [Bug 222100] [css-grid] Fix min/max widths of grid affected by ancestor

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=222100

--- Comment #16 from Oriol Brufau <obrufau at igalia.com> ---
Comment on attachment 422134
  --> https://bugs.webkit.org/attachment.cgi?id=422134
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422134&action=review

>> Source/WebCore/rendering/RenderBox.cpp:2499
>> +    if (needsPreferredWidthsRecalculation() && shouldRecalculateMinMaxWidthsAffectedByAncestor(this) && parent()->preferredLogicalWidthsDirty()) {
> 
> I think we should have a check here for parent(); I believe it's not guaranteed that it's not null.

Why does WebKit need parent()->preferredLogicalWidthsDirty() if Chromium doesn't have it?
And maybe the condition should be moved into shouldRecalculateMinMaxWidthsAffectedByAncestor() ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210304/878ff352/attachment-0001.htm>