[Webkit-unassigned] [Bug 220662] std::is_literal_type causes -Wdeprecated-declarations warning with GCC 11

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=220662

--- Comment #7 from Michael Catanzaro <mcatanzaro at gnome.org> ---
It's not necessarily hard, but we use it in a lot of places, and it requires more time than I have available to adjust them all.

I also attempted to hoist std::variant and its related methods (std::get, std::visit, std::holds_alternative) into the WTF namespace, but failed at that too. We also have one customization, WTF::switchOn, that could justify keeping wtf/Variant.h even if we were to successfully migrate to std::variant.

Next I tried adjusting the code to no longer use std::is_literal_type, but after squinting for a while I decided I'd better not touch it.

I tried searching for an updated version of our variant, but the upstream no longer exists.

I tried searching for a new upstream that we could use. https://github.com/mpark/variant/ looks like a good option, and it's license-compatible. One compiler warning seems like not a very great reason to switch from one implementation to another, though. 

I'm just going to silence the warning. This function is removed from C++ 20, but I assume libstdc++ and libc++ will both keep it around forever. If it ever gets removed, then we'll need to revisit.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210303/a02b0e0e/attachment-0001.htm>