[Webkit-unassigned] [Bug 222448] [MSE] Overlapping MediaSamples are not deleted
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 1 21:20:26 PST 2021
https://bugs.webkit.org/show_bug.cgi?id=222448
--- Comment #7 from Toshio Ogasawara <toshio.ogasawara at access-company.com> ---
(In reply to Jer Noble from comment #4)
> Comment on attachment 421614 [details]
> patch
>
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=421614&action=review
>
> > Source/WebCore/platform/graphics/SourceBufferPrivate.cpp:1141
> > - // If highest presentation timestamp for track buffer is set and less than or equal to presentation timestamp
> > - if (trackBuffer.highestPresentationTimestamp.isValid() && trackBuffer.highestPresentationTimestamp - contiguousFrameTolerance <= presentationTimestamp) {
> > + // If highest presentation timestamp for track buffer is set and less than frame end timestamp.
> > + if (trackBuffer.highestPresentationTimestamp.isValid() && trackBuffer.highestPresentationTimestamp - contiguousFrameTolerance < frameEndTimestamp) {
>
> This text comes directly from the MSE standard, and it looks like it has
> been changed since this comment was written. The new text of "3.5.8 Coded
> Frame Processing" step 1.14, part 2 says:
>
> > If highest end timestamp for track buffer is set and less than or equal to presentation timestamp:
>
> It looks like we do correctly set "highestPresentationTimestamp" to the
> "frame end timestamp" later in step 1.19, but I do wonder if there were
> other changes to the specification around "frame end timestamp" that may
> have been missed. So your proposed change would be a willful departure from
> the text of the specification. Should this be brought up to the MSE spec
> authors first? Or is there another way to solve the issue you're attempting
> to fix?
I will ask 'https://github.com/w3c/media-source/issues' about this issue.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210302/35f74822/attachment.htm>
More information about the webkit-unassigned
mailing list