[Webkit-unassigned] [Bug 222406] Render tree updates for Text node content mutations should happen during rendering update

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 1 14:26:14 PST 2021


https://bugs.webkit.org/show_bug.cgi?id=222406

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com

--- Comment #21 from Darin Adler <darin at apple.com> ---
Comment on attachment 421738
  --> https://bugs.webkit.org/attachment.cgi?id=421738
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421738&action=review

> Source/WebCore/style/StyleUpdate.cpp:104
> +    auto result = m_texts.ensure(&text, [&] {
> +        return WTFMove(textUpdate);
> +    });

I think this is identical to:

    auto result = m_texts.add(&text, WTFMove(textUpdate));

Maybe because it looks like WTFMove causes a "move" that the ensure form seems safer, but pretty sure it’s no different.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210301/4b915f9e/attachment-0001.htm>


More information about the webkit-unassigned mailing list