[Webkit-unassigned] [Bug 222555] Use PriorityQueue in NetworkCache::Storage

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 1 10:00:57 PST 2021


https://bugs.webkit.org/show_bug.cgi?id=222555

Chris Dumez <cdumez at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #421840|review?                     |review+
              Flags|                            |

--- Comment #4 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 421840
  --> https://bugs.webkit.org/attachment.cgi?id=421840
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421840&action=review

r=me

> Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp:61
> +    static uint64_t ordinal;

I had to look up ordinal in a dictionary but it holds up :)

> Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h:187
> +    PriorityQueue<std::unique_ptr<ReadOperation>, &isHigherPriority> m_pendingReadOperations;

We may be able to use UniqueRef instead of unique_ptr?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210301/66ce6366/attachment.htm>


More information about the webkit-unassigned mailing list