[Webkit-unassigned] [Bug 226883] Web Inspector: add contextual documentation for CSS properties

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=226883

--- Comment #16 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 432421
  --> https://bugs.webkit.org/attachment.cgi?id=432421
Patch v1.3 - preprocessed database, refactored and moved code to right files,renamed files

View in context: https://bugs.webkit.org/attachment.cgi?id=432421&action=review

> Source/WebInspectorUI/UserInterface/External/ContextualDocumentationDatabase/ContextualDocumentationDatabase.js:1
> +ContextualDocumentationDatabase = {

Are we planning to upload the script that creates this too?  If not, why not?

>> Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsPanel.css:55
>> +    height: 10px;
> 
> Why are we making this smaller than the 15px it used to be? It feels like if this button fit, the new on should fit as well at the same height?

Yeah.  Also, AFAICT this is unrelated to this change, so please undo this and make it into a separate bug/patch.

> Source/WebInspectorUI/UserInterface/Views/ContextualDocumentationPopover.css:32
> +.popover .documentation-popover > p {

Is the `.popover` needed?

>> Source/WebInspectorUI/UserInterface/Views/ContextualDocumentationPopover.js:98
>> +            referenceLinkElement.textContent = "MDN Reference";
> 
> NIT: I'd reverse these two lines to better match the order you do the other elements in.

Also, if you're not going to have things in the UI that do to NOT want to localize then please use `WI.unlocalizedString`.

> Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:95
> +:matches(.spreadsheet-style-declaration-editor.properties, .computed-property-item) > .property:hover > .content> .contextual-documentation-button {

ditto (:91)

Also, I think you can combine this with the above by using
```
    .spreadsheet-style-declaration-editor > .property:not(:hover) > .content > .contextual-documentation-button {
        display: none;
    }
```

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210629/a1d47776/attachment.htm>