[Webkit-unassigned] [Bug 219354] [GStreamer] SleepDisabler not created when "Skip Ads" is used to start a YouTube video

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=219354

Michael Catanzaro <mcatanzaro at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.webkit.org/sho
                   |                            |w_bug.cgi?id=192530

--- Comment #10 from Michael Catanzaro <mcatanzaro at gnome.org> ---
(In reply to Philippe Normand from comment #9)
> We'd need to instrument the media element code:

No problem!

> - is updateSleepDisabling() being called?

Yes, a lot.

> - if so, is shouldDisableSleep() returning something different than
> SleepType::None?

No, it always returns SleepType::None (0 in the prints below) except once when playing the ad:

$ jhbuild run epiphany
updateSleepDisabling: m_player=(nil) 0
updateSleepDisabling: m_player=(nil) 0
updateSleepDisabling: m_player=(nil) 0
updateSleepDisabling: m_player=(nil) 0
updateSleepDisabling: m_player=0x7faf940f7910 0
updateSleepDisabling: m_player=0x7faf940f7bc8 0
updateSleepDisabling: m_player=(nil) 0
updateSleepDisabling: m_player=(nil) 0
updateSleepDisabling: m_player=0x7faf9015acb0 0
updateSleepDisabling: m_player=(nil) 0
updateSleepDisabling: m_player=(nil) 0
updateSleepDisabling: m_player=0x7faf98d541d0 0
updateSleepDisabling: m_player=0x7faf98d542b8 0
updateSleepDisabling: m_player=0x7faf98d542b8 0
updateSleepDisabling: m_player=0x7faf98d542b8 0
updateSleepDisabling: m_player=0x7faf98d542b8 0
updateSleepDisabling: m_player=0x7faf5894cd98 0
updateSleepDisabling: m_player=0x7faf57777000 0
updateSleepDisabling: m_player=(nil) 0
updateSleepDisabling: m_player=(nil) 0
updateSleepDisabling: m_player=0x7faf57777570 0
updateSleepDisabling: m_player=0x7faf57777658 0
updateSleepDisabling: m_player=0x7faf57777658 0
updateSleepDisabling: m_player=0x7faf57777658 0
updateSleepDisabling: m_player=0x7faf57777658 0
updateSleepDisabling: m_player=0x7faf57777658 0
updateSleepDisabling: m_player=0x7faf57777658 0
SleepDisablerGLib
updateSleepDisabling: m_player=0x7faf57777658 1
~SleepDisablerGLib
updateSleepDisabling: m_player=0x7faf577771d0 0
updateSleepDisabling: m_player=(nil) 0
updateSleepDisabling: m_player=(nil) 0
updateSleepDisabling: m_player=0x7faf577772b8 0
updateSleepDisabling: m_player=0x7faf57777658 0
updateSleepDisabling: m_player=0x7faf57777658 0
updateSleepDisabling: m_player=0x7faf57777658 0
updateSleepDisabling: m_player=0x7faf57777658 0
updateSleepDisabling: m_player=(nil) 0
updateSleepDisabling: m_player=(nil) 0

Note that m_player changing to NULL during video playback seems weird. We had another bug report for that, but I can't find it anymore.

I added even more debug in shouldDisableSleep, on all the codepaths that return SleepType::None:

shouldDisableSleep: m_sentEvent=0 m_player=(nil) m_player->paused=0 loop()=0
updateSleepDisabling: m_player=(nil) 0
shouldDisableSleep: m_sentEvent=0 m_player=(nil) m_player->paused=0 loop()=0
updateSleepDisabling: m_player=(nil) 0
shouldDisableSleep: m_sentEvent=0 m_player=(nil) m_player->paused=0 loop()=0
updateSleepDisabling: m_player=(nil) 0
shouldDisableSleep: m_sentEvent=0 m_player=(nil) m_player->paused=0 loop()=0
updateSleepDisabling: m_player=(nil) 0
shouldDisableSleep: m_sentEvent=0 m_player=0x7f811efd2910 m_player->paused=1 loop()=0
updateSleepDisabling: m_player=0x7f811efd2910 0
shouldDisableSleep: m_sentEvent=0 m_player=0x7f811efd2bc8 m_player->paused=1 loop()=0
updateSleepDisabling: m_player=0x7f811efd2bc8 0
shouldDisableSleep: m_sentEvent=0 m_player=(nil) m_player->paused=0 loop()=0
updateSleepDisabling: m_player=(nil) 0
shouldDisableSleep: m_sentEvent=0 m_player=(nil) m_player->paused=0 loop()=0
updateSleepDisabling: m_player=(nil) 0
shouldDisableSleep: m_sentEvent=0 m_player=0x7f811b22dae0 m_player->paused=1 loop()=0
updateSleepDisabling: m_player=0x7f811b22dae0 0
shouldDisableSleep: m_sentEvent=0 m_player=(nil) m_player->paused=0 loop()=0
updateSleepDisabling: m_player=(nil) 0
shouldDisableSleep: m_sentEvent=0 m_player=(nil) m_player->paused=0 loop()=0
updateSleepDisabling: m_player=(nil) 0
shouldDisableSleep: m_sentEvent=0 m_player=0x7f811b22de80 m_player->paused=1 loop()=0
updateSleepDisabling: m_player=0x7f811b22de80 0
shouldDisableSleep: m_sentEvent=0 m_player=0x7f811e21d000 m_player->paused=1 loop()=0
updateSleepDisabling: m_player=0x7f811e21d000 0
shouldDisableSleep: m_sentEvent=0 m_player=0x7f811e21d000 m_player->paused=1 loop()=0
updateSleepDisabling: m_player=0x7f811e21d000 0
shouldDisableSleep: m_sentEvent=0 m_player=0x7f811e21d000 m_player->paused=1 loop()=0
updateSleepDisabling: m_player=0x7f811e21d000 0
shouldDisableSleep: m_sentEvent=0 m_player=0x7f811e21d000 m_player->paused=1 loop()=0
updateSleepDisabling: m_player=0x7f811e21d000 0
shouldDisableSleep: m_sentEvent=0 m_player=0x7f811e21d000 m_player->paused=1 loop()=0
updateSleepDisabling: m_player=0x7f811e21d000 0
shouldDisableSleep: m_sentEvent=0 m_player=0x7f811e21d000 m_player->paused=1 loop()=0
updateSleepDisabling: m_player=0x7f811e21d000 0
SleepDisablerGLib
updateSleepDisabling: m_player=0x7f811e21d000 1
shouldDisableSleep: m_sentEvent=0 m_player=0x7f80e91c5570 m_player->paused=1 loop()=0
~SleepDisablerGLib
updateSleepDisabling: m_player=0x7f80e91c5570 0
shouldDisableSleep: m_sentEvent=0 m_player=(nil) m_player->paused=0 loop()=0
updateSleepDisabling: m_player=(nil) 0
shouldDisableSleep: m_sentEvent=0 m_player=(nil) m_player->paused=0 loop()=0
updateSleepDisabling: m_player=(nil) 0
shouldDisableSleep: m_sentEvent=0 m_player=0x7f80ea525cb0 m_player->paused=1 loop()=0
updateSleepDisabling: m_player=0x7f80ea525cb0 0
shouldDisableSleep: m_sentEvent=0 m_player=0x7f80ea525d98 m_player->paused=1 loop()=0
updateSleepDisabling: m_player=0x7f80ea525d98 0
shouldDisableSleep: m_sentEvent=0 m_player=0x7f80ea525d98 m_player->paused=1 loop()=0
updateSleepDisabling: m_player=0x7f80ea525d98 0
shouldDisableSleep: m_sentEvent=0 m_player=0x7f80ea525d98 m_player->paused=1 loop()=0
updateSleepDisabling: m_player=0x7f80ea525d98 0
shouldDisableSleep: m_sentEvent=0 m_player=0x7f80ea525d98 m_player->paused=1 loop()=0
updateSleepDisabling: m_player=0x7f80ea525d98 0
shouldDisableSleep: m_sentEvent=0 m_player=(nil) m_player->paused=0 loop()=0
updateSleepDisabling: m_player=(nil) 0
shouldDisableSleep: m_sentEvent=0 m_player=(nil) m_player->paused=0 loop()=0
updateSleepDisabling: m_player=(nil) 0

Clearly the problem is that m_player=(nil) when MSE is enabled, which is really weird. That's why the check fails. I thought we had another old bug for this, but I can't find it. I see I mentioned this same problem in bug #192530 though, so that's proof that it's not a new surprise.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210628/8dec7aac/attachment-0001.htm>