[Webkit-unassigned] [Bug 226986] Refactor MacOS keyboard scrolling and use KeyboardScroll struct

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 22 11:37:30 PDT 2021


https://bugs.webkit.org/show_bug.cgi?id=226986

--- Comment #17 from Tim Horton <thorton at apple.com> ---
Comment on attachment 431979
  --> https://bugs.webkit.org/attachment.cgi?id=431979
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431979&action=review

Need to get the bots not red and clean up some random files that you don't need to touch, but this seems pretty much ready to go.

> Source/WebCore/page/EventHandler.cpp:4192
> -
> +    

What editor are you using that is making all these spurious changes :) If it's Xcode, check "including white-space only lines" in the "editing" tab of "text editing"

> Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm:315
> +        eventWasHandled = executeKeypressCommandsInternal(commands, &event); 

?

> Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm:456
> +    // // First give accessibility a chance to handle the event.

What's this!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210622/edbf70c8/attachment-0001.htm>


More information about the webkit-unassigned mailing list