[Webkit-unassigned] [Bug 226986] Refactor MacOS keyboard scrolling and use KeyboardScroll struct

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=226986

--- Comment #11 from Aditya Keerthi <akeerthi at apple.com> ---
Comment on attachment 431719
  --> https://bugs.webkit.org/attachment.cgi?id=431719
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431719&action=review

> Source/WebCore/ChangeLog:3
> +        Renavigate MacOS keyboard scrolling and use KeyboardScroll struct

Nit: Update to match bug title.

> Source/WebCore/page/EventHandler.cpp:4193
> +    

You should configure your editor to remove trailing spaces :)

> Source/WebCore/page/EventHandler.cpp:4209
> +    

Nit: Unnecessary newline.

> Source/WebCore/page/EventHandler.cpp:4250
> +        return {0, -1};

Nit: Add spaces around the values, like `{ 0, -1 };`.

> Source/WebCore/page/EventHandler.cpp:4260
> +CGFloat EventHandler::ScrollDistance(WebCore::ScrollingDirection direction, WebCore::ScrollingIncrement increment)

Nit: `scrollDistance`.

> Source/WebCore/page/EventHandler.cpp:4263
> +    FrameView* view = frame->view();

`m_frame.view()`. No need for the local variable.

> Source/WebCore/page/EventHandler.cpp:4351
> +    scroll.maximumVelocity = scroll.offset.scaled(this->parameters().maximumVelocityMultiplier);
> +
> +    scroll.force = scroll.maximumVelocity.scaled(this->parameters().springMass / this->parameters().timeToMaximumVelocity);

Remove `this`.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210618/d52b17e4/attachment.htm>