[Webkit-unassigned] [Bug 215986] [WPE] 2.29.90: build faiils when ENABLE_API_TESTS=ON

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=215986

Adrian Perez <aperez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aperez at igalia.com

--- Comment #5 from Adrian Perez <aperez at igalia.com> ---
(In reply to Tomasz Kłoczko from comment #4)
> So why do not add some files to dist tar ball to allow post package build
> fire WebKit test suite to confirm that at least some basic WebKit 
> functionalities are OK?

I suppose tests that use the public API would not increase much the size
of release tarballs, but we would need a new CMake build option to allow
building those without trying to also build the rest of testing tools.

Including the whole set of files needed for testing would be a staggering
+2 GiB added to the size of unpacked sources, see:

   % du -hs LayoutTests/ JSTests/ Tools/TestWebKitAPI/ \
            Tools/WebKitTestRunner/ WebDriverTests/             
   1,8G    LayoutTests/
   316M    JSTests/
   24M     Tools/TestWebKitAPI/
   2,5M    Tools/WebKitTestRunner/
   %

It looks quite impractical to include all this in release tarballs for
little gain, given that every change gets tested both by the WebKit EWS
infrastructure (at https://ews-build.webkit.org/) and then again after
the commit gets landed (at https://build.webkit.org/).

> Please really understand that executing such test suites is very important
> from point of view maintaining whole OS distributions where WebKit  is only
> one component of something way bigger.
>
> [...]

If you take a look at how the WebKit project at large does extensive
testing, I think it should be quite clear that we 100% agree with you
and that tests are extremely important :)

I do not have the time to look right now into including the API tests
in release tarballs, but I could find some time to review such a patch
if someone else can write it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210616/2b741c62/attachment-0001.htm>