[Webkit-unassigned] [Bug 227017] Rewrite NetworkCache::Data::adoptMap not to use FileSystem::MappedFileData::leakHandle

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=227017

--- Comment #3 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 431411
  --> https://bugs.webkit.org/attachment.cgi?id=431411
WIP patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431411&action=review

>> Source/WebKit/NetworkProcess/cache/NetworkCacheDataCocoa.mm:98
>> +    const void* map = mappedFile.data();
> 
> Which do you need to change Cocoa code? The new code is less efficient.

This change isn't technically a mandatory for Bug 227017.
I can keep FileSystem::MappedFileData::leakHande just for this.

Because Bug 227017 is going to add HANDLE of a file mapping to
MappedFileData, the combination of
FileSystem::MappedFileData::leakHande and
FileSystem::unmapViewOfFile is too problematic.
That's the reason I want to remove.

But, I can keep MappedFileData::leakHande by adding #if !OS(WINDOWS) if you like.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210615/b53f8a1e/attachment.htm>