[Webkit-unassigned] [Bug 197002] [GTK] Support transient zoom

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=197002

Michael Catanzaro <mcatanzaro at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #431424|review?                     |review+
              Flags|                            |

--- Comment #29 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 431424
  --> https://bugs.webkit.org/attachment.cgi?id=431424
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431424&action=review

> Source/WebKit/UIProcess/ViewGestureController.h:488
> +    static constexpr double minMagnification { 1 };
> +    static constexpr double maxMagnification { 3 };

I think const will suffice here. You probably don't need the constexpr?

> Source/WebKit/UIProcess/mac/ViewGestureControllerMac.mm:-54
> -static const double minMagnification = 1;
> -static const double maxMagnification = 3;

OK, EWS is sad. Looks like resistanceForDelta would need to become a static class function, since it uses these but no longer has access to them.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210615/282e654b/attachment-0001.htm>