[Webkit-unassigned] [Bug 197002] [GTK] Support transient zoom

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=197002

Tim Horton <thorton at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |thorton at apple.com

--- Comment #24 from Tim Horton <thorton at apple.com> ---
Comment on attachment 430846
  --> https://bugs.webkit.org/attachment.cgi?id=430846
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430846&action=review

The Mac/iOS/shared VGC changes seem fine to me, but final review should come from a GTK person since I can't speak to those parts.

> Source/WebKit/UIProcess/ViewGestureController.cpp:65
> +static const double minMagnification = 1;
> +static const double maxMagnification = 3;

Maybe you can expose these on the class, so that...

> Source/WebKit/UIProcess/gtk/ViewGestureControllerGtk.cpp:67
> +static const double minMagnification = 1;
> +static const double maxMagnification = 3;

... we don't have to repeat ourselves?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210614/98cb8909/attachment.htm>