[Webkit-unassigned] [Bug 226986] Renavigate MacOS keyboard scrolling and use KeyboardScroll struct

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=226986

--- Comment #3 from Tim Horton <thorton at apple.com> ---
(In reply to Tim Horton from comment #2)
> Comment on attachment 431359 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=431359&action=review
> 
> > Source/WebCore/page/EventHandler.cpp:4302
> > +    else if (event.keyIdentifier() == "PageDown")
> > +        key = Key::PageDown;
> > +    else if (event.keyIdentifier() == "PageUp")
> > +        key = Key::PageUp;
> 
> PageDown is not going to get to defaultArrowEventHandler, likely this all
> needs to be factored out and called from multiple places (some kind of
> "maybe handle keyboard scroll" function)

Also don't forget about the spacebar.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210614/5eabfea9/attachment.htm>