[Webkit-unassigned] [Bug 222985] [GTK] WebKitWebView::show-option-menu introspection is broken, should use --warn-error when building gir

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=222985

Michael Catanzaro <mcatanzaro at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mcatanzaro at gnome.org
            Summary|[GTK] Use --warn-error when |[GTK]
                   |building gir                |WebKitWebView::show-option-
                   |                            |menu introspection is
                   |                            |broken, should use
                   |                            |--warn-error when building
                   |                            |gir

--- Comment #1 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Looks like the WPE version of our introspection is winning:

      <glib:signal name="show-option-menu" when="last" version="2.28">
        <doc xml:space="preserve"
             filename="../Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp"
             line="2207">This signal is emitted when a select element in @web_view needs to display a
dropdown menu. This signal can be used to show a custom menu, using @menu to get
the details of all items that should be displayed. The area of the element in the
#WebKitWebView is given as @rectangle parameter, it can be used to position the
menu.
To handle this signal asynchronously you should keep a ref of the @menu.</doc>
        <return-value transfer-ownership="none">
          <doc xml:space="preserve"
               filename="../Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp"
               line="2220">%TRUE to stop other handlers from being invoked for the event.
  %FALSE to propagate the event further.</doc>
          <type name="gboolean" c:type="gboolean"/>
        </return-value>
        <parameters>
          <parameter name="object" transfer-ownership="none">
            <type name="OptionMenu"/>
          </parameter>
          <parameter name="p0" transfer-ownership="none">
            <type name="Gdk.Event"/>
          </parameter>
          <parameter name="p1" transfer-ownership="none">
            <type name="Gdk.Rectangle"/>
          </parameter>
        </parameters>
      </glib:signal>

So... that's bad.

I've tried various ways of passing -DPLATFORM_GTK to the introspection scanner, but I'm not having much luck. I got it to work by splitting the signal declaration out into the GTK and WPE files.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210609/465cdc24/attachment-0001.htm>