[Webkit-unassigned] [Bug 226817] [JSC] Fix incorrect register reuse in 32bit after r278568

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=226817

Caio Lima <ticaiolima at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #430963|review?                     |review+
              Flags|                            |

--- Comment #4 from Caio Lima <ticaiolima at gmail.com> ---
Comment on attachment 430963
  --> https://bugs.webkit.org/attachment.cgi?id=430963
Fix incorrect register reuse

View in context: https://bugs.webkit.org/attachment.cgi?id=430963&action=review

r=me

>> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:7388
>> +    GPRTemporary result(this);
> 
> Could we try to still reuse it, but then move 0 after `notEqual.link(&m_jit);` on line 7404? I think this would allow us to reuse left and right payload/tag there.

Never mind, this would require another jump for Equals case. Not reusing the tag sounds a better compromise then generating multiple branchs

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210609/74a6d368/attachment.htm>