[Webkit-unassigned] [Bug 212327] [GTK4] Add support for navigation gestures

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=212327

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |simon.fraser at apple.com

--- Comment #17 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 429857
  --> https://bugs.webkit.org/attachment.cgi?id=429857
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429857&action=review

>>> Source/WebKit/UIProcess/ViewSnapshotStore.h:89
>>> +    size_t estimateImageSizeInBytes() const { return m_surface ? m_surface->totalBytes() : 0; }
>> 
>> Hi Chris, we need an owner for this... can you approve this change please?
>> 
>> The problem is our new ViewSnapshotStore implementation doesn't actually know for sure how large its snapshots are -- that's hidden behind an abstraction layer -- so we have to guess. It means the cache size limit won't be perfectly respected if our guess is wrong. Won't make a difference for Apple ports since your "estimate" is not changed and will always be exact.
> 
> Hi owners, we just need this function name change approved please.

I approve estimatedImageSizeInBytes() (note the rename).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210609/76dcbc0f/attachment-0001.htm>