[Webkit-unassigned] [Bug 197002] [GTK] Support transient zoom

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=197002

--- Comment #21 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 430826
  --> https://bugs.webkit.org/attachment.cgi?id=430826
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430826&action=review

LGTM, but I'm afraid we're going to need to find an owner willing to review this due to extensive changes in cross-platform WK2.

> Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp:153
> +#if PLATFORM(GTK)
> +    if (!m_transientZoom)
> +#endif
> +        flags.add(FinalizeRenderingUpdateFlags::ApplyScrollingTreeLayerPositions);

Style nit: don't do this please, just write it out twice:

#if PLATFORM(GTK)
    if (!m_transientZoom)
        flags.add(FinalizeRenderingUpdateFlags::ApplyScrollingTreeLayerPositions);
#else
    flags.add(FinalizeRenderingUpdateFlags::ApplyScrollingTreeLayerPositions);
#endif

> Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp:207
> +#if PLATFORM(GTK)
> +        if (!m_transientZoom)
> +#endif

Ditto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210608/d9ca7ec3/attachment.htm>