[Webkit-unassigned] [Bug 226573] New: [GStreamer] Enforce clang thread safety annotations

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 3 02:36:56 PDT 2021


https://bugs.webkit.org/show_bug.cgi?id=226573

            Bug ID: 226573
           Summary: [GStreamer] Enforce clang thread safety annotations
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKitGTK
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: aboya at igalia.com
                CC: bugs-noreply at webkitgtk.org

This patch:

(1) Finishes the work done by Chris Dumez in r278248, fixing the
    warnings when using DataMutexLocker::runUnlocked() and
    DataMutex::earlyUnlock().

(2) Fixes almost all* thread safety warnings in platform/graphics/gstreamer.

(3) Introduces WTF_BEGIN_ENFORCE_THREAD_SAFETY_ANALYSIS and
    WTF_END_ENFORCE_THREAD_SAFETY_ANALYSIS macros which turn thread safety
    warnings into compile-time errors when building in clang.

(4) Makes use of WTF_BEGIN_ENFORCE_THREAD_SAFETY_ANALYSIS in almost
    all* files in platform/graphics/gstreamer that make use of locks, and
    in the DataMutex unit test suite.

*Exceptionally, ImageDecoderGStreamer.cpp hasn't been modified to add
the enforce annotation because of race condition present detected by
the analyzer. Fixing that is a separate issue in
https://bugs.webkit.org/show_bug.cgi?id=226495.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210603/59e4705f/attachment.htm>


More information about the webkit-unassigned mailing list