[Webkit-unassigned] [Bug 226383] Adopt Reveal for phone numbers

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 1 13:57:37 PDT 2021


https://bugs.webkit.org/show_bug.cgi?id=226383

Tim Horton <thorton at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #430284|review?                     |review+
              Flags|                            |

--- Comment #13 from Tim Horton <thorton at apple.com> ---
Comment on attachment 430284
  --> https://bugs.webkit.org/attachment.cgi?id=430284
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430284&action=review

> Source/WebKit/Platform/mac/MenuUtilities.mm:121
> +    auto context = adoptNS([PAL::allocRVPresentingContextInstance() initWithPointerLocationInView:NSZeroPoint inView:viewForPresenter.get() highlightDelegate:delegate.get()]);

I wonder if we should ask Reveal folks (separately from this bug) for API that doesn't take a view/point (or, if we do so and they tell us why that's a bad idea, we'll understand why faking it like this is bad).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210601/040b37d5/attachment-0001.htm>


More information about the webkit-unassigned mailing list