[Webkit-unassigned] [Bug 226369] REGRESSION(r276882): Style not invalidated correctly for media queries in shadow trees that share style

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=226369

--- Comment #7 from Ryosuke Niwa <rniwa at webkit.org> ---
(In reply to Sam Weinig from comment #6)
> (In reply to Antti Koivisto from comment #5)
> > > As these scopes are WeakPtrs, what is guaranteeing they are alive? Do they
> > > really have to be WeakPtrs? Given how short lived this Vector is, could they
> > > Ref<>s? Should you be null checking them?
> > 
> > Logically they are guaranteed to be non-null. I'm just using WeakPtrs
> > defensively here.
> 
> I guess we can't use Refs as they are not reference counted. It's going to
> take me some time (if ever) to become comfortable with defensive use of
> WeakPtr :(.

I'm adding CheckedPtr for this exact use case: https://bugs.webkit.org/show_bug.cgi?id=226158

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210601/d45f174e/attachment.htm>