[Webkit-unassigned] [Bug 226495] New: [GStreamer] clang analysis: Unlocked access in ImageDecoderGStreamer.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=226495

            Bug ID: 226495
           Summary: [GStreamer] clang analysis: Unlocked access in
                    ImageDecoderGStreamer.cpp
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKitGTK
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: aboya at igalia.com
                CC: bugs-noreply at webkitgtk.org

In ImageDecoderGStreamer.cpp, line 384:

        if (!decoder.m_messageDispatched) {
            Locker locker { decoder.m_messageLock };
            decoder.m_messageCondition.wait(decoder.m_messageLock);
        }

m_messageDispatched is guarded by m_messageLock (see ImageDecoderGStreamer.h):

    bool m_messageDispatched WTF_GUARDED_BY_LOCK(m_messageLock) { false };

Yet the value is being checked before taking the lock. I don't know how it should work but it sure looks like it shouldn't be that way given those guard preconditions.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210601/14046e5e/attachment.htm>