[Webkit-unassigned] [Bug 228122] Expand URL class query parameter functions

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 30 17:06:56 PDT 2021


--- Comment #18 from John Wilander <wilander at apple.com> ---
Comment on attachment 434669
  --> https://bugs.webkit.org/attachment.cgi?id=434669

View in context: https://bugs.webkit.org/attachment.cgi?id=434669&action=review

Good suggestions from Darin.

>> Source/WTF/ChangeLog:8
>> +        Added more functionalities for parsing URL query parameters.
> I don’t fully understand why adding more functions that are not yet used is important for WebKIt, but I trust there is some reason.

I'd say "Added parsing of URL query strings."

> Tools/TestWebKitAPI/Tests/WTF/URL.cpp:522
> +    EXPECT_EQ(url9.string(), url12.string());

You need to have a section of negative tests, for instance named URLMalformedQueryStrings. There your test things like:
· http://www.webkit.org/??
· http://www.webkit.org/?/?test=test
· http://www.webkit.org/?=test
· http://www.webkit.org/?==
· http://www.webkit.org/?=?
· http://www.webkit.org/=?
· http://www.webkit.org??
· http://www.webkit.org?/?test=test
· http://www.webkit.org?=test
· http://www.webkit.org?==
· http://www.webkit.org?=?
· http://www.webkit.org=?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210731/c6c3b2dd/attachment.htm>

More information about the webkit-unassigned mailing list