[Webkit-unassigned] [Bug 228548] Replace -webkit-*-* logical properties by standard logical properties in WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=228548

--- Comment #24 from Patrick Angle <pangle at apple.com> ---
Comment on attachment 434601
  --> https://bugs.webkit.org/attachment.cgi?id=434601
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434601&action=review

>>> Source/WebInspectorUI/ChangeLog:3
>>> +        Web Inspector: Add standard logical properties in WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js
>> 
>> Shouldn't we also add update ContextualDocumentationDatabase.js to add the unprefixed properties ?
> 
> And it seems the JetStream test is also using these -webkit-* values to test WebInspector CSSKeywordCompletions, so this is related to the change here too.
> I wonder whether you should call this "Web Inspector: Add standard logical properties to CSS keyword completion".
> 
> PerformanceTests/JetStream2/code-load/inspector-payload.js
> PerformanceTests/JetStream2/code-load/inspector-payload-minified.js
> Websites/browserbench.org/JetStream2.0/code-load/inspector-payload-minified.js
> Websites/browserbench.org/JetStream2.0/code-load/inspector-payload.js
> 
> BTW, bugzilla's bug title should be updated too.

`ContextualDocumentationDatabase.js` is a file derived from information in the `vscode-custom-data` open source project, so we shouldn't add anything manually. Properties without documentation available are gracefully handled, so the presence of an entry in that file is not required.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210730/68b10f5c/attachment.htm>