[Webkit-unassigned] [Bug 163483] WaylandCompositor.cpp should define MESA_EGL_NO_X11_HEADERS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=163483

--- Comment #4 from Adrian Perez <aperez at igalia.com> ---
(In reply to Haelwenn (lanodan) Monnier from comment #3)
> Well it sure would be better to use pkg-config files but it doesn't seems to
> work.
> 
> > Mesa pkg-config file (mesa.pc)
> 
> I do not have a mesa.pc

I was sleepy when I wrote this. I meant “egl.pc”

> [0] $ pkg-config --path mesa
> [1] $ qlist mesa | grep mesa.pc
> [1] $
> 
> > libwpe as example
> 
> libwpe is among the packages where I need to add -DEGL_NO_X11 for it to
> build on my libX11-free setup (gentoo system with USE=-X).
> 
> As you seem to hint, maybe the blame of not defining -DEGL_NO_X11 when X is
> disabled lies on the provider of egl.pc? For me it's libGLVND.

Sounds like libGLVND should include the needed flags in “egl.pc”. 

Using Mesa's (without libGLVND) works as expected; for example I have
a Wayland only Buildroot configuration here right know which contains
this:

  % cat output-rpi3-wpe/staging/usr/lib/pkgconfig/egl.pc   
  prefix=/usr
  libdir=${prefix}/lib
  includedir=${prefix}/include

  Name: egl
  Description: Mesa EGL Library
  Version: 21.1.5
  Requires.private: libdrm >=  2.4.75
  Libs: -L${libdir} -lEGL
  Libs.private: -lpthread -pthread -lm
  Cflags: -I${includedir} -DEGL_NO_X11
  %

I see at https://github.com/NVIDIA/libglvnd/blob/master/src/EGL/egl.pc.in
that libGLVND's “egl.pc.in” template does not put anything in the “Cflags:”
field. Probably nobody thought about it when X11 support was made optional
in libGLVND in https://github.com/NVIDIA/libglvnd/pull/184 ��

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210730/1011aa07/attachment.htm>