[Webkit-unassigned] [Bug 163483] WaylandCompositor.cpp should define MESA_EGL_NO_X11_HEADERS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=163483

Adrian Perez <aperez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aperez at igalia.com

--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
The correct thing to do here is picking the compiler flags from
the Mesa pkg-config file (mesa.pc) correctly, using the _CFLAGS_OTHER
variable defined by CMake's find_package() command. For example this
was done here:

  https://github.com/WebPlatformForEmbedded/libwpe/pull/4/

Hardcoding a certain -DFOO will not work in all cases because different
drivers may need different compiler options. The suggested options are
Mesa-specific, but will fail for example with the proprietary Vivante
drivers that target Wayland or the framebuffer. Picking the correct
flags from the .pc file should work for all reasonable drivers :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210729/8e6b99c6/attachment.htm>