[Webkit-unassigned] [Bug 228536] [Win][Uniscribe] Remove the code rounding off glyph advances and offsets for non system fonts

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 28 14:55:05 PDT 2021


--- Comment #4 from Fujii Hironori <Hironori.Fujii at sony.com> ---
In WinCairo, this patch makes the following ref tests fail.

  fast/text/emoji-gender-3.html [ ImageOnlyFailure ]
  fast/text/emoji-gender-4.html [ ImageOnlyFailure ]
  fast/text/emoji-gender-5.html [ ImageOnlyFailure ]
  fast/text/emoji-gender-6.html [ ImageOnlyFailure ]
  fast/text/emoji-gender-8.html [ ImageOnlyFailure ]

This is caused by the difference of how to get glyph advance between simple text code path and complex text code path.
The simple text code path is using cairo_scaled_font_glyph_extents, the complex text code path is using Uniscribe to get the glyph advance.

I think the simple text code path also should use Uniscribe.

However, the argument of Font::platformWidthForGlyph is Glyph not UChar.
Uniscribe (ScriptShape) takes a string, not glyphs.

Another approach is implementing Font::applyTransforms with Uniscribe (Bug 228363).
However, Font::applyTransforms is not applied to a single character.
This approach needs some modification to WidthIterator.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210728/27b7273a/attachment-0001.htm>

More information about the webkit-unassigned mailing list