[Webkit-unassigned] [Bug 228155] macOS key-driven smooth scrolling does not work for spacebar

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=228155

Tim Horton <thorton at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #434226|review-                     |review+
              Flags|                            |

--- Comment #5 from Tim Horton <thorton at apple.com> ---
Comment on attachment 434226
  --> https://bugs.webkit.org/attachment.cgi?id=434226
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434226&action=review

>> Source/WebCore/platform/KeyboardScrollingAnimator.cpp:237
>> +    if (!(event.type() == eventNames().keydownEvent || event.type() == eventNames().keypressEvent))
> 
> Hmm, I'm not sure this is right. Are you not getting `keydown` for the spacebar? If not, you probably want to figure out who is eating it.

I guess it's OK (a bit weird, but existing weirdness); EventHandler::defaultSpaceEventHandler itself asserts it's only called with keypress, and the other callers of this call it explicitly only for keydown, so we won't get duplicates.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210728/d9261aa3/attachment.htm>