[Webkit-unassigned] [Bug 228363] [Win][Uniscribe] Implement Font::applyTransforms

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 27 23:58:25 PDT 2021


--- Comment #6 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 434314
  --> https://bugs.webkit.org/attachment.cgi?id=434314
WIP patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434314&action=review

>> Source/WebCore/platform/graphics/win/ComplexTextControllerUniscribe.cpp:353
>> +            const float cLogicalScale = platformData().useGDI() ? 1 : 32;
> Is this really correct?

The code was added by r28867. It should be correct. However, I want to remove the code
  Bug 206273 – [Win] Remove obsolete useGDI code path and FontRenderingMode enum

>> Source/WebCore/platform/graphics/win/ComplexTextControllerUniscribe.cpp:362
>> +                offsetY = roundf(offsetY);
> This is almost certainly not necessary (any more).

I copied this code from UniscribeController::shapeAndPlaceItem. OK, I will remove the code.
  Bug 228536 – [Win][Uniscribe] Remove the code rounding off glyph advances and offsets for system fonts

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210728/f2d753eb/attachment.htm>

More information about the webkit-unassigned mailing list